chore(Cross): [IOAPPX-213] Remove pivotal from danger and changelog scripts #5422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagopa-github-bot
changed the title
Affected stories
|
LazyAfternoons
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5422 +/- ##
==========================================
- Coverage 48.20% 47.29% -0.91%
==========================================
Files 1417 1460 +43
Lines 30539 31314 +775
Branches 7503 7606 +103
==========================================
+ Hits 14722 14811 +89
- Misses 15749 16445 +696
+ Partials 68 58 -10
... and 69 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
LazyAfternoons
added
the
💀 Dead matter
LazyAfternoons
changed the title
LazyAfternoons
changed the title
pagopa-github-bot
changed the title
pagopa-github-bot
changed the title
pagopa-github-bot
changed the title
pagopa-github-bot
changed the title
LazyAfternoons
changed the title
LazyAfternoons
changed the title
pagopa-github-bot
changed the title
LazyAfternoons
added a commit
that referenced
this pull request
Apr 11, 2024
## Short description This PR fixes a regression introduced by [this PR](#5422) which prevents danger from displaying the proper message for PR without ticket numbers ([example](#5296 (comment))) or wrong ticket numbers ([example](#4384 (comment))). Please notice that the whole script might be simplified drastically, thus we could refactor it in the future but the scope of these PRs is to remove the support for `pivotal`. ## List of changes proposed in this pull request - Implements a check to verify if the result of `getJiraIdFromPrTitle` returns an empty array. If so, it is now explicitly returned, and subsequently utilized in `commentPrWithTicketsInfo` to send the appropriate message; - If a ticket number is detected in the PR title, `getTicketsFromTitle` now directly returns the result of `getJiraTickets`. This adjustment aligns with the approach previously utilized [here](https://github.com/pagopa/io-app/pull/2935/files#diff-8ec5aa024b8a7cf5ead4ccf7f60297c3cdca64e13a74216867bc74914829a435R44), beside the mapping to a generic ticket type which is not needed anymore. ## How to test Static checks but you can also check the history of the `pagopa-github-bot` message. As you can see I tested this without a ticket number, with a wrong ticket number, with multiple ticket numbers and also with the actual ticket number. --------- Co-authored-by: Cristiano Tofani <[email protected]> Co-authored-by: Fabio Bombardi <[email protected]>
CrisTofani
added a commit
that referenced
this pull request
Apr 12, 2024
## Short description This PR fixes a regression introduced by [this PR](#5422) which prevents danger from displaying the proper message for PR without ticket numbers ([example](#5296 (comment))) or wrong ticket numbers ([example](#4384 (comment))). Please notice that the whole script might be simplified drastically, thus we could refactor it in the future but the scope of these PRs is to remove the support for `pivotal`. ## List of changes proposed in this pull request - Implements a check to verify if the result of `getJiraIdFromPrTitle` returns an empty array. If so, it is now explicitly returned, and subsequently utilized in `commentPrWithTicketsInfo` to send the appropriate message; - If a ticket number is detected in the PR title, `getTicketsFromTitle` now directly returns the result of `getJiraTickets`. This adjustment aligns with the approach previously utilized [here](https://github.com/pagopa/io-app/pull/2935/files#diff-8ec5aa024b8a7cf5ead4ccf7f60297c3cdca64e13a74216867bc74914829a435R44), beside the mapping to a generic ticket type which is not needed anymore. ## How to test Static checks but you can also check the history of the `pagopa-github-bot` message. As you can see I tested this without a ticket number, with a wrong ticket number, with multiple ticket numbers and also with the actual ticket number. --------- Co-authored-by: Cristiano Tofani <[email protected]> Co-authored-by: Fabio Bombardi <[email protected]>
CrisTofani
added a commit
that referenced
this pull request
Apr 12, 2024
## Short description This PR fixes a regression introduced by [this PR](#5422) which prevents danger from displaying the proper message for PR without ticket numbers ([example](#5296 (comment))) or wrong ticket numbers ([example](#4384 (comment))). Please notice that the whole script might be simplified drastically, thus we could refactor it in the future but the scope of these PRs is to remove the support for `pivotal`. ## List of changes proposed in this pull request - Implements a check to verify if the result of `getJiraIdFromPrTitle` returns an empty array. If so, it is now explicitly returned, and subsequently utilized in `commentPrWithTicketsInfo` to send the appropriate message; - If a ticket number is detected in the PR title, `getTicketsFromTitle` now directly returns the result of `getJiraTickets`. This adjustment aligns with the approach previously utilized [here](https://github.com/pagopa/io-app/pull/2935/files#diff-8ec5aa024b8a7cf5ead4ccf7f60297c3cdca64e13a74216867bc74914829a435R44), beside the mapping to a generic ticket type which is not needed anymore. ## How to test Static checks but you can also check the history of the `pagopa-github-bot` message. As you can see I tested this without a ticket number, with a wrong ticket number, with multiple ticket numbers and also with the actual ticket number. --------- Co-authored-by: Cristiano Tofani <[email protected]> Co-authored-by: Fabio Bombardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR addresses the removal of Pivotal Tracker integration from our danger and changelog scripts, as it has been replaced by Jira.
List of changes proposed in this pull request
danger-plugin-digitalcitizenshipandpivotaljs, with the former being a plugin with custom rules over Danger;IOAPPXboard;How to test
Static checks and tests. I also made a few tests by editing this PR title and running Danger to check its behavior, as you can tell by this messages history.
The changelog can be generated locally by testing any release command or the script directly.